-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed issues related to DBEncryption in RSDBPersistentManager and enhanced error handling #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallabmaiti
suggested changes
Oct 3, 2023
…stead of encrypted or unencrypted ones for event storage
pallabmaiti
previously approved these changes
Oct 4, 2023
1abhishekpandey
previously approved these changes
Oct 4, 2023
pallabmaiti
previously approved these changes
Oct 4, 2023
desusai7
dismissed stale reviews from pallabmaiti and 1abhishekpandey
via
October 5, 2023 07:14
6f99ad8
pallabmaiti
previously approved these changes
Oct 6, 2023
1abhishekpandey
approved these changes
Oct 9, 2023
itsdebs
approved these changes
Oct 9, 2023
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SQLCipher
is available during run time when theDBEncryption feature is enabled
, if not then the SDK will log anerror message to the developer to ensure that the SQLCipher is linked well to the project
.createDB
method of RSDBPersistentManager toreduce its cognitive complexity
by breaking down the method into multiple methods.RSDBPersistentManager
:keep writing events to the unencrypted database despite the developer enabling the encryption
.keep writing events to the encrypted database despite the developer disabling the encryption
.keep writing events to the encrypted database despite the developer disabling the encryption
.